Commented added template and cut of DCAxy#1072
Merged
Merged
Conversation
sarahherrmann
requested review from
aalkin,
alibuild,
aortizve and
ddobrigk
as code owners
aalkin
previously approved these changes
Jul 28, 2022
auto-merge was automatically disabled
July 28, 2022 15:45
Head branch was pushed to by a user without write access
aalkin
previously approved these changes
Jul 28, 2022
aalkin
approved these changes
Jul 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added some comments for readability, I put a template to avoid writing twice the same process function with just a small variation, and I implemented the DCAxy cut. The ambiguous tracks having a DCAxy > maxDCAXY will just stay ambiguous.